Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log error messages and clean up monitor when indexing doc level queri… #1478

Closed
wants to merge 4 commits into from
Closed

log error messages and clean up monitor when indexing doc level queri… #1478

wants to merge 4 commits into from

Conversation

goyamegh
Copy link
Collaborator

…es or metadata creation fails (#900)

  • log errors and clean up monitor when indexing doc level queries or metadata creation fails
  • refactor delete monitor action to re-use delete methods
    Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

eirsep and others added 3 commits March 14, 2024 22:56
@eirsep @goyamegh
log error messages and clean up monitor when indexing doc level queri…
d5413af 
…es or metadata creation fails (opensearch-project#900)

* log errors and clean up monitor when indexing doc level queries or metadata creation fails
* refactor delete monitor action to re-use delete methods
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@sbcd90 @goyamegh
optimize doc-level monitor workflow for index patterns (opensearch-pr…
65c5f51 
…oject#1122)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@goyamegh
Merge conflicts
40a1c4b 
Signed-off-by: Megha Goyal <goyamegh@amazon.com>
@goyamegh goyamegh force-pushed the 2.7-backports branch 5 times, most recently from cf9ead1 to 61feb78 Compare March 15, 2024 18:28
@engechas
Copy link
Collaborator

CI is failing

REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.DocumentMonitorRunnerIT.test execute monitor generates alerts and findings with per alert execution for actions" -Dtests.seed=D611385684093386 -Dtests.security.manager=false -Dtests.locale=lt -Dtests.timezone=America/Paramaribo -Druntime.java=17
org.opensearch.alerting.DocumentMonitorRunnerIT > test execute monitor generates alerts and findings with per alert execution for actions FAILED
    java.util.NoSuchElementException: List is empty.
        at __randomizedtesting.SeedInfo.seed([D611385684093386:28F5267A0603560E]:0)
        at kotlin.collections.CollectionsKt___CollectionsKt.first(_Collections.kt:212)
        at org.opensearch.alerting.DocumentMonitorRunnerIT.test execute monitor generates alerts and findings with per alert execution for actions(DocumentMonitorRunnerIT.kt:259)

Will rerun once

@engechas
Copy link
Collaborator

Same test failed again (there's also a number of other failures)

org.opensearch.alerting.DocumentMonitorRunnerIT > test execute monitor generates alerts and findings with per alert execution for actions FAILED
    java.util.NoSuchElementException: List is empty.
        at __randomizedtesting.SeedInfo.seed([340552357EBF6165:CAE14C19FCB504ED]:0)
        at kotlin.collections.CollectionsKt___CollectionsKt.first(_Collections.kt:212)
        at org.opensearch.alerting.DocumentMonitorRunnerIT.test execute monitor generates alerts and findings with per alert execution for actions(DocumentMonitorRunnerIT.kt:259)
REPRODUCE WITH: ./gradlew ':alerting:integTest' --tests "org.opensearch.alerting.DocumentMonitorRunnerIT.test execute monitor generates alerts and findings with per alert execution for actions" -Dtests.seed=340552357EBF6165 -Dtests.security.manager=false -Dtests.locale=hr-HR -Dtests.timezone=Australia/Darwin -Druntime.java=17

@engechas
Copy link
Collaborator

Backports for 2.7 were previously completed. Closing this PR

@engechas engechas closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goyamegh @engechas @eirsep @sbcd90